v1.2.4.7

README.md

@@ -52,7 +52,7 @@ With the new config system, block tags and custom blockstates can be used to mas
 ![players sitting on a vast range of blocks](https://github.com/Oth3r/oth3r.github.io/blob/main/mod_data/Sit!/media/desc/custom_blocks.gif?raw=true)
 
 ### ⌨️ Keybinds
-Don't want to sit with the **just** the hand? Use a keybind or type a command to sit instead!
+Don't want to sit with **just** the hand? Use a keybind or type a command to sit instead!
 
 ![setting keybinds for the sit mod, and sitting by using them](https://github.com/Oth3r/oth3r.github.io/blob/main/mod_data/Sit!/media/desc/keybinds.gif?raw=true)
 

changelog.md

@@ -1,3 +1,6 @@
+# v1.2.4.7
+* fixed legacy file updater causing a stack overflow crash
+
 # v1.2.4.6
 * fixed max otterlib version (1.21.8)
 

gradle.properties

@@ -13,7 +13,7 @@ yarn_mappings=1.21.8+build.1
 loader_version=0.16.14
 
 # Mod Properties
-mod_version=1.2.4.6+1.21.8
+mod_version=1.2.4.7+1.21.8
 maven_group=one.oth3r
 file_name=sit!
 

src/main/java/one/oth3r/sit/file/ServerConfig.java

@@ -345,6 +345,11 @@ public class ServerConfig implements CustomFile<ServerConfig> {
             } catch (Exception e) {
                 Data.LOGGER.error("Failed to delete the old Sit! config.");
             }
+
+            // save the updated configs
+            FileData.saveFiles();
+
+            // continue loading as normal...
         }
 
         /**
@@ -494,8 +499,6 @@ public class ServerConfig implements CustomFile<ServerConfig> {
 
                 FileData.setServerConfig(serverConfig);
                 FileData.setSittingConfig(sittingConfig);
-                serverConfig.save();
-                sittingConfig.save();
             } catch (Exception e) {
                 Data.LOGGER.error("Error loading legacy config: %s", e.getMessage());
             }