From 1bb8409931d525214f7dadbe579917a774c6e947 Mon Sep 17 00:00:00 2001 From: Oth3r <68134921+oth3r@users.noreply.github.com> Date: Sat, 19 Jul 2025 20:53:00 -0500 Subject: [PATCH 1/3] grammer fix --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 22fec77..fb8170b 100644 --- a/README.md +++ b/README.md @@ -52,7 +52,7 @@ With the new config system, block tags and custom blockstates can be used to mas ![players sitting on a vast range of blocks](https://github.com/Oth3r/oth3r.github.io/blob/main/mod_data/Sit!/media/desc/custom_blocks.gif?raw=true) ### ⌨️ Keybinds -Don't want to sit with the **just** the hand? Use a keybind or type a command to sit instead! +Don't want to sit with **just** the hand? Use a keybind or type a command to sit instead! ![setting keybinds for the sit mod, and sitting by using them](https://github.com/Oth3r/oth3r.github.io/blob/main/mod_data/Sit!/media/desc/keybinds.gif?raw=true) From 89536e307071007808e0fa8a0e653d3c1b10fd34 Mon Sep 17 00:00:00 2001 From: Oth3r <68134921+oth3r@users.noreply.github.com> Date: Sat, 19 Jul 2025 20:53:37 -0500 Subject: [PATCH 2/3] fix legacy file updater causing a stack overflow crash --- src/main/java/one/oth3r/sit/file/ServerConfig.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/one/oth3r/sit/file/ServerConfig.java b/src/main/java/one/oth3r/sit/file/ServerConfig.java index 8a36ad3..660c14c 100644 --- a/src/main/java/one/oth3r/sit/file/ServerConfig.java +++ b/src/main/java/one/oth3r/sit/file/ServerConfig.java @@ -345,6 +345,11 @@ public class ServerConfig implements CustomFile { } catch (Exception e) { Data.LOGGER.error("Failed to delete the old Sit! config."); } + + // save the updated configs + FileData.saveFiles(); + + // continue loading as normal... } /** @@ -494,8 +499,6 @@ public class ServerConfig implements CustomFile { FileData.setServerConfig(serverConfig); FileData.setSittingConfig(sittingConfig); - serverConfig.save(); - sittingConfig.save(); } catch (Exception e) { Data.LOGGER.error("Error loading legacy config: %s", e.getMessage()); } From ce9a88d56de90390370530764bdd325d966da936 Mon Sep 17 00:00:00 2001 From: Oth3r <68134921+oth3r@users.noreply.github.com> Date: Sat, 19 Jul 2025 20:54:26 -0500 Subject: [PATCH 3/3] v1.2.4.7 --- changelog.md | 3 +++ gradle.properties | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index 7fac970..6c48664 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,6 @@ +# v1.2.4.7 +* fixed legacy file updater causing a stack overflow crash + # v1.2.4.6 * fixed max otterlib version (1.21.8) diff --git a/gradle.properties b/gradle.properties index ff05bfd..9fcfc73 100644 --- a/gradle.properties +++ b/gradle.properties @@ -13,7 +13,7 @@ yarn_mappings=1.21.8+build.1 loader_version=0.16.14 # Mod Properties -mod_version=1.2.4.6+1.21.8 +mod_version=1.2.4.7+1.21.8 maven_group=one.oth3r file_name=sit!